[PATCH] D64971: [SafeStack] Insert the deref after the offset

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 15:44:59 PDT 2019


vsk added a comment.

  include/llvm/BinaryFormat/Dwarf.h:  DW_OP_LLVM_fragment = 0x1000,   ///< Only used in LLVM metadata.
  
   856     case dwarf::DW_OP_LLVM_fragment:                                                                                                                                         
   857       // A fragment operator must appear at the end.                                                                                                                         
   858       return I->get() + I->getSize() == E->get(); 

So the deref needs to happen before the fragment. Something like: `DIExpression::prepend(Expr, DerefAfter, Offset)`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64971/new/

https://reviews.llvm.org/D64971





More information about the llvm-commits mailing list