[PATCH] D65040: [llvm-objcopy] Add support for --add-section for COFF

[Sergey Dmitriev via Phabricator via llvm-commits]

sdmitriev marked 7 inline comments as done.
sdmitriev added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/add-section.test:38
+    SectionData:     488B0500000000C3
+symbols:
+...
----------------
jhenderson wrote:
> Does yaml2obj allow this line to be deleted?
No, 'symbols' is a required keyword.


================
Comment at: llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp:95
+
+  auto Contents = createGnuDebugLinkSectionContents(DebugLinkFile);
+
----------------
jhenderson wrote:
> You can delete the empty lines before and after this line. Also, what is the type of Contents here? LLVM style is to not use auto in this sort of situation, as the type is not obvious from context.
Sure, I have deleted empty lines. 'Contents' has type std::vector<uint8_t> since it is a result of the createGnuDebugLinkSectionContents() function call which is defined several lines above, but, anyway, I have replaced auto with explicit type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65040/new/

https://reviews.llvm.org/D65040