[PATCH] D65142: [RISCV] Implement benchmark::cycleclock::Now for riscv64-linux

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 10:09:30 PDT 2019


lenary accepted this revision.
lenary added a comment.

Looks good. Small nit below, but beyond that all is fine.



================
Comment at: libcxx/utils/google-benchmark/README.LLVM:9
+Changes:
+* https://github.com/google/benchmark/commit/4abdfbb802d1b514703223f5f852ce4a507d32d2
+  is applied to add RISC-V timer support.
----------------
rogfer01 wrote:
> I couldn't tell exactly on what version this copy is based, hope this wording is fine.
It seems to be based on https://github.com/google/benchmark/commit/4528c76b718acc9b57956f63069c699ae21edcab - might be worth noting this in the readme. (This commit is between v1.4.1 and v1.5.0).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65142/new/

https://reviews.llvm.org/D65142





More information about the llvm-commits mailing list