[PATCH] D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D65121#1597553 <https://reviews.llvm.org/D65121#1597553>, @probinson wrote:

> In D65121#1597516 <https://reviews.llvm.org/D65121#1597516>, @jdenny wrote:
>
> > In D65121#1597486 <https://reviews.llvm.org/D65121#1597486>, @probinson wrote:
> >
> > > The lit part seems like a good thing.  It's unfortunate that lit/test/lit.cfg needs to know about FileCheck environment variables, but them's the breaks.
> >
> >
> > If this issue were present in more test suites, I'd be tempted to extend FileCheck with a command-line option to encapsulate this use case in some manner.  As things are, that doesn't seem worth the trouble to me, but maybe others feel differently.
>
>
> Then every test that had this issue would have to be modified to add the option.


I was thinking of a command-line option that prints something like `-u FILECHECK_OPTS -u FILECHECK_DUMP_INPUT_ON_FAILURE`.  The idea is that `lit/test/lit.cfg` wouldn't need to maintain a list of variables.

>   I think it would have to be an environment variable that suppresses the other environment variables: `FILECHECK_IGNORE_ENV=1` or something. Then test suites could add that in their config files, and tests would be written as normal.

Makes sense too.

> Luckily, so far we don't seem to need that level of confusion.

Agreed.  It's just one external test suite, and there's no evidence the list of variables is going to evolve much further.  `FILECHECK_OPTS` is intended to be a catch-all.  `FILECHECK_DUMP_INPUT_ON_FAILURE` is deprecated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65121/new/

https://reviews.llvm.org/D65121