[PATCH] D65136: [llvm-objdump] - Import the test/Object/X86/no-start-symbol.test test case and rewrite it to use YAML.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 03:14:11 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added a subscriber: rupprecht.

This patch removes `test/Object/X86/no-start-symbol.test` (rewrites
it to use YAML and moves it to llvm-objdump tests folder).

(This test was initially introduced in rL239039 <https://reviews.llvm.org/rL239039>, but now there
is no reason to keep the precompiled binary it seems).


https://reviews.llvm.org/D65136

Files:
  test/Object/Inputs/no-start-symbol.elf-x86_64
  test/Object/X86/no-start-symbol.test
  test/tools/llvm-objdump/X86/disassemble-no-symbol-at-section-start.test


Index: test/tools/llvm-objdump/X86/disassemble-no-symbol-at-section-start.test
===================================================================
--- /dev/null
+++ test/tools/llvm-objdump/X86/disassemble-no-symbol-at-section-start.test
@@ -0,0 +1,28 @@
+## Test that we disassemble the start of the section even
+## if there is no start symbol.
+
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objdump -d %t | FileCheck %s
+
+# CHECK: Disassembly of section .text:
+# CHECK-EMPTY:
+# CHECK-NEXT:  .text:
+# CHECK-NEXT:    0: 90 nop
+# CHECK:       foo:
+# CHECK-NEXT:    1: 90 nop
+
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_REL
+  Machine: EM_X86_64
+Sections:
+  - Name:    .text
+    Type:    SHT_PROGBITS
+    Flags:   [ SHF_ALLOC, SHF_EXECINSTR ]
+    Content: '9090'
+Symbols:
+  - Name:    foo
+    Section: .text
+    Value:   0x0000000000000001
Index: test/Object/X86/no-start-symbol.test
===================================================================
--- test/Object/X86/no-start-symbol.test
+++ /dev/null
@@ -1,10 +0,0 @@
-RUN: llvm-objdump -d %p/../Inputs/no-start-symbol.elf-x86_64 | FileCheck %s
-
-Test that we disassemble the start of the section.
-
-CHECK: Disassembly of section .text:
-CHECK-EMPTY:
-CHECK-NEXT:  .text:
-CHECK-NEXT:       0:	90 	nop
-CHECK: foo:
-CHECK-NEXT:       1:	90 	nop


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65136.211269.patch
Type: text/x-patch
Size: 1353 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190723/cb68dfd2/attachment.bin>


More information about the llvm-commits mailing list