[PATCH] D64384: [WIP] Index-while-building

[Jan Korous via Phabricator via llvm-commits]

jkorous marked 4 inline comments as done.
jkorous added a comment.

Thanks for taking a look Sam!

I finished porting of all the changes on top of llvm.org master in the meantime. The updated patch contains all the code we'd like to land. Build (on macOS) and tests are fine.
I'll leave it as a single patch for now so we can finish discussion about layering and I'll split it into couple smaller patches once this is done.

I've put the actual index-while-building part into separate subdirectories for now. For now I went with IndexWhileBuilding name but I'm open to discussion.



================
Comment at: clang/include/clang/Index/GenerateIndexAction.h:34
+  class IndexDataConsumer;
+  class IndexUnitWriter;
+
----------------
sammccall wrote:
> (this seems like suspicious layering, but also seems to be unused)
Right. Removed.


================
Comment at: clang/lib/Index/GenerateIndexAction.cpp:11
+
+#include "clang/Index/IndexDataFormat.h"
+#include "IndexPPCallbacks.h"
----------------
sammccall wrote:
> I can't tell where this is used - it's suspicious if required
Removed. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64384/new/

https://reviews.llvm.org/D64384