[PATCH] D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3.

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

I'm very sorry for the slow reply.

> So how do we progress from here? What you're describing to me (no iOS simulator asan dylib if iOS simulator SDKs not present in toolchain) is expected behaviour. The issue you mention with the iOS simulator asan dylib no longer being produced does sound very curious. However you are using a modified toolchain that I do not have so I cannot reproduce the change in behaviour. Does this behaviour change matter to you?

Yes, because we use that ios simulator asan dylib.

> If not, I think we should just land this patch. If it does matter then please be aware that this was the intended behaviour and the fact it used to work is an accident. If necessary some time could be invested into to figuring out why the behaviour changed but either you would need to investigate this yourself or provide a copy of the toolchain you are using so I can investigate.

I think the way forward is for us to just make sure we have the full xcode available when building our clang package. But we need to figure out how to coax our infrastructure into making that happen..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63674/new/

https://reviews.llvm.org/D63674