[PATCH] D64871: [llvm-lipo] Implement alignment function in -create

Anusha Basana via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 14:31:26 PDT 2019


anushabasana marked 3 inline comments as done.
anushabasana added inline comments.


================
Comment at: llvm/test/tools/llvm-lipo/Inputs/CPU10-slice.yaml:1
+--- !mach-o
+FileHeader:      
----------------
compnerd wrote:
> CPU10 is not particularly helpful.  Would be nice to use the human readable form (m88k).
This file and CPU14 are both intended to go into calculateSegmentAlignment() since they are not any of the valid architectures. I just manually changes the CPU types for testing. What would the best naming convention be for this situation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64871/new/

https://reviews.llvm.org/D64871





More information about the llvm-commits mailing list