[PATCH] D65060: [LICM] Make Loop ICM profile aware

Mon Jul 22 11:58:14 PDT 2019

xbolva00 added a comment.

In D65060#1596152 <https://reviews.llvm.org/D65060#1596152>, @davidxl wrote:

> This was tried before. IIRC, the conclusion was to implement look sinking pass to undo non-profitable LICM. The loop sinking pass was in D22778 <https://reviews.llvm.org/D22778>.    Can the loop sinking pass be enhanced to handle the case here ( I have not looked in details) ?

Folks want disable LICM with metadata - https://reviews.llvm.org/D64557 - to just workaround this LICM issue. If we know (this patch) that we should not hoist instrs, why to hoist them and undo them?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65060/new/

https://reviews.llvm.org/D65060