[PATCH] D64971: [SafeStack] Insert the deref after the offset

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.

In D64971#1593801 <https://reviews.llvm.org/D64971#1593801>, @probinson wrote:

> So the deref ought to go after the arithmetic, and not before.  Then someplace that knows the difference between values and locations can remove the deref so the resulting expression is ultimately correct in the DWARF?


Ahhhhhh,

Vedant wrote:

> Thanks, LGTM. @jmorse any outstanding concerns?

I think this'll work fine with stack_value too, LGTM, thanks for the patch @phosek .

(On the broader issue, I think the DWARF expression code does some guessing about what it's dealing with because it's not especially well defined what context a DIExpression works in, and it can change. Definitely something for further discussion somewhere else).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64971/new/

https://reviews.llvm.org/D64971