[PATCH] D64819: [UpdateTestChecks][Bug41532] Add handle of basic block names.

Whitney via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 07:53:26 PDT 2019


Whitney marked an inline comment as done.
Whitney added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:139
 # spaces, commas, paren, or end of the string
-IR_VALUE_RE = re.compile(r'(\s+)%([\w\.\-]+?)([,\s\(\)]|\Z)')
+IR_VALUE_RE = re.compile(r'(\s+%)([\w\.\-]+?)([,\s\(\)]|\Z)')
+
----------------
MaskRay wrote:
> I'm concerned that the `%` change will create a huge amount of diff.
> 
> Can you make the updated form only apply to labels?
I am trying to figure out how to match all variables which doesn't have prefix "label".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64819/new/

https://reviews.llvm.org/D64819





More information about the llvm-commits mailing list