[PATCH] D65059: [ARM] Better OR's for MVE compares

[Dave Green via Phabricator via llvm-commits]

dmgreen marked 2 inline comments as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:11850
+  unsigned Opposite1 = 0;
+  for (auto Code : InvertCodes) {
+    if (N0->getOpcode() == Code.Opcode)
----------------
SjoerdMeijer wrote:
> I am wondering if a map is easier as a data structure here so that you can just do a lookup and don't need the for-loop here?
I think it may be simpler to just deal with condition codes directly, as in D65072. It allows us to just use the existing methods for getting inverse nodes, for example.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65059/new/

https://reviews.llvm.org/D65059