[PATCH] D63847: [MC] Add MCInstrAnalysis::evaluateMemoryOperandAddress

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 21 22:29:48 PDT 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp:522
+    const MCInst &Inst, uint64_t Addr, uint64_t Size) const {
+  MCInstrDesc Opcode = Info->get(Inst.getOpcode());
+  int MemOpStart = X86II::getMemoryOperandNo(Opcode.TSFlags);
----------------
"const MCInstrDesc &MCID" or "const MCInstr &Desc"  would be better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63847/new/

https://reviews.llvm.org/D63847





More information about the llvm-commits mailing list