[PATCH] D64876: [Attributor] Deduce "dereferenceable" attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

This LGTM assuming you tried it on the test suite. Clang format the patch please and see the two comments below.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1229
+  /// Bits encoding for NonNullGlobalState.
+  enum Deref {
+    DEREF_NONNULL = 1 << 0,
----------------
Change the name to something meaningful or remove it, should not be necessary anyway.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1395
+    Attributor &A, Value &V, bool &IsNonNull, bool &IsGlobal) {
+  // TODO: Tracking the globally and nonnull flag.
+
----------------
if you do not track them, set them to false. I think tracking nonnull should be easy, you compute it below almost in all cases anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64876/new/

https://reviews.llvm.org/D64876