[PATCH] D65015: Enable CodeGenOpt::None on non-iOS ARM

Nicolas Capens via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 13:34:09 PDT 2019


capn created this revision.
Herald added subscribers: llvm-commits, hiraditya, kristof.beyls, javed.absar.
Herald added a project: LLVM.

FastISel didn't work on MCJIT for non-iOS ARM, back in 2013 (r183966).
This appears to have been fixed since.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65015

Files:
  llvm/lib/ExecutionEngine/TargetSelect.cpp


Index: llvm/lib/ExecutionEngine/TargetSelect.cpp
===================================================================
--- llvm/lib/ExecutionEngine/TargetSelect.cpp
+++ llvm/lib/ExecutionEngine/TargetSelect.cpp
@@ -83,13 +83,6 @@
     FeaturesStr = Features.getString();
   }
 
-  // FIXME: non-iOS ARM FastISel is broken with MCJIT.
-  if (TheTriple.getArch() == Triple::arm &&
-      !TheTriple.isiOS() &&
-      OptLevel == CodeGenOpt::None) {
-    OptLevel = CodeGenOpt::Less;
-  }
-
   // Allocate a target...
   TargetMachine *Target =
       TheTarget->createTargetMachine(TheTriple.getTriple(), MCPU, FeaturesStr,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65015.210886.patch
Type: text/x-patch
Size: 620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190719/16bdae9d/attachment.bin>


More information about the llvm-commits mailing list