[PATCH] D64984: [Verifier] Verify all blockaddress constants left over have at least one user.

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

Hello @fhahn , it looks like more tests are failing on tip 7df225dfc25adc8371188dc57f3adf300b0bd697 <https://reviews.llvm.org/rG7df225dfc25adc8371188dc57f3adf300b0bd697> when I tested on x86_64:

  Failing Tests (4):
      LLVM :: CodeGen/X86/retpoline.ll
      LLVM :: CodeGen/X86/speculative-load-hardening-indirect.ll
      LLVM :: Transforms/ConstProp/basictest.ll
      LLVM :: Transforms/IndirectBrExpand/basic.ll



================
Comment at: llvm/lib/IR/Verifier.cpp:4985
+    Assert(!KV.second->use_empty(), "Blockaddress does not have any users",
+           KV.second);
+}
----------------
Is it possible to add the name of the block/function to this assert? When looking at `basic.ll` I wasn't sure if the block in question was `bb` or `entry` of `@test2()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64984/new/

https://reviews.llvm.org/D64984