[PATCH] D64971: [SafeStack] Don't re-insert derefs for allocas in debug info

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D64971#1593801 <https://reviews.llvm.org/D64971#1593801>, @probinson wrote:

> (I though Reid was going to invent dbg.addr and solve all this nonsense for us...)


Yeah, that was the plan, but I don't see myself finding time to work on it. :(

I think at this point Jeremy is more familiar with the current state of things. From the way I understand things, we need a deref in the IR DIExpression somewhere to indicate that the variable value is not the pointer itself, but is the value in memory addressed by the pointer. Looking at things now, I would expect the deref to go *after* the pointer arithmetic, but I'm not confident if that will flow through the rest of LLVM correctly.

In any case, I don't think this patch as written is the right fix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64971/new/

https://reviews.llvm.org/D64971