[PATCH] D64971: [SafeStack] Don't re-insert derefs for allocas in debug info

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 09:02:39 PDT 2019


vsk added a reviewer: debug-info.
vsk added a comment.

Thanks for the patch.

I’m not sure why you don’t still need the deref after applying the correct offset. IIUC the post-patch DIExpression used to describe “value” actually describes its address. Is that intentional / were you able to check that a debugger prints the right thing post-patch?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64971/new/

https://reviews.llvm.org/D64971





More information about the llvm-commits mailing list