[PATCH] D64927: lld-link: Demangle symbols from archives in diagnostics

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 06:26:50 PDT 2019


thakis marked 2 inline comments as done.
thakis added inline comments.


================
Comment at: lld/COFF/SymbolTable.h:86
   Symbol *addUndefined(StringRef name, InputFile *f, bool isWeakAlias);
-  void addLazy(ArchiveFile *f, const Archive::Symbol sym);
+  void addLazy(ArchiveFile *f, const Archive::Symbol& sym);
   Symbol *addAbsolute(StringRef n, COFFSymbolRef s);
----------------
ruiu wrote:
> nit: `& ` -> ` &`
Ran `git diff master | clang/tools/clang-format/clang-format-diff.py -p1` and fixed most things it printed (mostly this, in .h and .cc), thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64927/new/

https://reviews.llvm.org/D64927





More information about the llvm-commits mailing list