[PATCH] D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 03:03:50 PDT 2019


sgraenitz added a comment.

Was this tested? I am not getting `APPLE` here:

  $ uname -s
  Darwin

https://cmake.org/cmake/help/v3.4/variable/CMAKE_HOST_SYSTEM_NAME.html says:

> On systems that have the uname command, this variable is set to the output of uname -s. Linux, Windows, and Darwin for Mac OS X are the values found on the big three operating systems.

What motivated the decision against `CMAKE_HOST_APPLE`?
https://cmake.org/cmake/help/v3.4/variable/CMAKE_HOST_APPLE.html


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64942/new/

https://reviews.llvm.org/D64942





More information about the llvm-commits mailing list