[PATCH] D64982: [AsmPrinter] Print label if MBB's address is taken

[Bill Wendling via Phabricator via llvm-commits]

void marked an inline comment as done.
void added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:438
                   MBB.getSymbol()->print(OS, AP->MAI);
+                  const_cast<MachineBasicBlock*>(&MBB)->setLabelMustBeEmitted();
                   break;
----------------
nickdesaulniers wrote:
> Make `MBB` a non-const `MachineBasicBlock&`, then you can drop the ugly `const_cast` and then also the `&` then `->` and just use `.`.
> 
> ```
> for (MachineBasicBlock& MBB : *MF) {
>   ...
>   MBB.setLabelMustBeEmitted();
> ```
The `MF` is coming from `MI` which itself is `const`. There's probably going to be a `const_cast` somewhere along the line. :-(


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64982/new/

https://reviews.llvm.org/D64982