[PATCH] D64892: [AMDGPU] Simplify AMDGPUInstPrinter::printRegOperand()

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 15:52:03 PDT 2019


rampitec marked 2 inline comments as done.
rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:323
+
+  O << StringRef(getRegisterName(RegNo, AltName)).lower();
 }
----------------
arsenm wrote:
> rampitec wrote:
> > arsenm wrote:
> > > Is the lower() still necessary?
> > I can lowercase all registers in td, then it will be not necessary.
> I thought the new generated names were lowercase already
Not really, but I have updated the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64892/new/

https://reviews.llvm.org/D64892





More information about the llvm-commits mailing list