[PATCH] D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 18 19:17:57 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/llvm-readobj/coff-file-headers.test:33
+# ARM64:File: [[FILE]]
+# ARM64-NEXT:Format: COFF-ARM64
+# ARM64-NEXT:Arch: aarch64
----------------
Due to `--strict-whitespace`, there are now no space after `NEXT:`. Just a question: do you find anything that requires `--strict-whitespace`?


================
Comment at: test/tools/llvm-readobj/elf-file-headers.test:2
+# RUN: yaml2obj %s --docnum=1 -o %t.i386
+# RUN: llvm-readobj -h %t.i386 | FileCheck %s --strict-whitespace --match-full-lines -DFILE=%t.i386 -check-prefix I386
+
----------------
Nit: `--check-prefix` since you use the double-dash form for `--strict-whitespace` and  `--match-full-lines`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64800/new/

https://reviews.llvm.org/D64800





More information about the llvm-commits mailing list