[PATCH] D64950: [WebAssembly] Use passive segments by default when memory is shared

Guanzhong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 18 14:23:09 PDT 2019


quantum added inline comments.


================
Comment at: lld/wasm/Driver.cpp:324-326
+      args.hasFlag(OPT_passive_segments, OPT_active_segments, false) ||
+      (config->sharedMemory &&
+       !args.hasFlag(OPT_active_segments, OPT_passive_segments, false));
----------------
This logic seems a bit hard to understand...

Would this work?

    args.hasFlag(OPT_passive_segments, OPT_active_segments, config->sharedMemory);



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64950/new/

https://reviews.llvm.org/D64950





More information about the llvm-commits mailing list