[PATCH] D60388: FileCheck [8/12]: Define numeric var from expr

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 18 06:44:25 PDT 2019


probinson added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:91
+; CHECK-LABEL: EMPTY NUM EXPR
+; CHECK-NEXT: foo [[#]] bar
+
----------------
thopre wrote:
> jhenderson wrote:
> > This is allowed? That's surprising to me, although I suppose it's a natural consequence of the rules.
> As you said it's a natural consequence and I thought it could actually be useful (to check you have a number in an error message but don't care about the value) so I didn't forbid it.
So `[[#]]` is equivalent to `{{[0-9]+}}` ?  Might be worth a note in the documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60388/new/

https://reviews.llvm.org/D60388





More information about the llvm-commits mailing list