[PATCH] D64903: [ELF] Pad the last page of last PF_X PT_LOAD with traps when -z separate-code is specified

Thu Jul 18 05:24:56 PDT 2019

peter.smith added a comment.

In D64903#1591226 <https://reviews.llvm.org/D64903#1591226>, @MaskRay wrote:

> > Would it also be possible to define what -zseparate-code is supposed to do in LLD?
>
> Update description to explain -z separate-code

Thanks for the update, I understand now that there could be some more work to be done on -zseparate-code.

I think that -zseparate-code is only default for x86-64 and there was a change to the default maxpagesize to compensate for the size. I'm also in favour of small image sizes particularly for the embedded use case and in certain resource constrained phones/laptops the size aggregated across a distro can be important. Would be good to hear from the implementers of D33630 <https://reviews.llvm.org/D33630> to check that they are happy to had -zseparate-code.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64903/new/

https://reviews.llvm.org/D64903