[PATCH] D64394: [MachineCSE][MachinePRE] Do not hoist common computations into hot BBs

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks. Looks like a nice change to me, other than one minor modification



================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:872
+                                        MachineBasicBlock *MBB1) {
+  if (CandidateBB->getParent()->getFunction().hasOptSize())
+    return true;
----------------
I think you can use hasMinSize, which is the truly size-paranoid option.

Os (hasOptSize) is probably fine with your new block frequency check, if it's expected to speed up some code (and the codesize changes are fairly minimal).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64394/new/

https://reviews.llvm.org/D64394