[PATCH] D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries

[Seiya Nuta via Phabricator via llvm-commits]

seiya marked 2 inline comments as done.
seiya added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp:61
+// Updates the index and the number of local/external/undefined symbols. Here we
+// assume that MLC is a LC_DYSYMTAB and the nlist entries in the symbol table
+// are already sorted by the those types.
----------------
alexshap wrote:
> I'd be defensive here: add an assert/logical check (for example, via std::is_sorted + custom comparator)
> + probably we probably need to actually sort at some point, don't we ?
Yes we will need to sort symbols when we support adding symbols.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63395/new/

https://reviews.llvm.org/D63395