[PATCH] D64882: [FileCheck] Fix @LINE substitution in error msg

Thu Jul 18 03:04:52 PDT 2019

jhenderson added a comment.

In D64882#1590997 <https://reviews.llvm.org/D64882#1590997>, @thopre wrote:

> In D64882#1590970 <https://reviews.llvm.org/D64882#1590970>, @jhenderson wrote:
>
> > I am wondering why we don't just have `setValue` call `clearValue` first in all cases?
>
>
> That's a remnant when each variable definition had its own variable and thus setting it twice didn't make sense and indicated an error. I think the right thing to do now is to change setValue to not check if the value is already set or not.

That seems reasonable to me. I think that would make this patch largely redundant, right?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64882/new/

https://reviews.llvm.org/D64882