[PATCH] D64903: [ELF] Pad the last page of last PF_X PT_LOAD with traps when -z separate-code is specified

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D64903#1590893 <https://reviews.llvm.org/D64903#1590893>, @grimar wrote:

> My first impression: seems adding the new `-z separate-code`/`-z noseparate-code` option is a good thing to do.


+1

> But it is probably arguable what should be the default. Can we just keep the existent behavior as a default?

The description summaries my reasoning why `-z noseparate-code` should be the default. `-z separate-code` is a dubious feature that reduces the number of ROP gadgets (which is actually very ineffective because attackers can find plenty of gadgets in the text segment, no need to find gadgets in non-code regions)


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64903/new/

https://reviews.llvm.org/D64903