[PATCH] D64746: Add constrained intrinsics for lrint and lround

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:118
 
+  case ISD::STRICT_LRINT:
+  case ISD::STRICT_LLRINT:
----------------
Why do these need to be handled here, but the none strict versions aren't?


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:174
   case ISD::STRICT_FTRUNC:
+  case ISD::STRICT_LROUND:
+  case ISD::STRICT_LLROUND:
----------------
We don't handle the non-vector version of these here. So I don't think we need to handle these yet.


================
Comment at: lib/IR/Verifier.cpp:4250
   case Intrinsic::experimental_constrained_log2:
+  case Intrinsic::experimental_constrained_lrint:
+  case Intrinsic::experimental_constrained_llrint:
----------------
Probably need to ensure these don't get used with vectors to match their none constrainted counterparts


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64746/new/

https://reviews.llvm.org/D64746