[PATCH] D64893: Ask confirmation when `git llvm push` will push multiple commits

[Alex Brachet via Phabricator via llvm-commits]

abrachet added inline comments.


================
Comment at: llvm/utils/git-svn/git-llvm:453
+    if len(revs) != 1:
+        if not ask_confirm("Are you sure?"):
+            die("abort")
----------------
Shouldn't the message be more descriptive? Maybe it should be "Multiple commits are about to be pushed. Are you sure?" The mailing list thread was specifically for newer contributors, right? I could imagine someone using `git llvm push` for the first time would imagine that was a normal message that is always given.


================
Comment at: llvm/utils/git-svn/git-llvm:454
+        if not ask_confirm("Are you sure?"):
+            die("abort")
+
----------------
Maybe "Did not proceed with pushing multiple commits" or at least "Aborting". Although I'm not sure any message is needed, probably just exiting is ok too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64893/new/

https://reviews.llvm.org/D64893