[PATCH] D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: thakis, cbiesinger.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

Until recently, `Python_ADDITIONAL_VERSIONS` was used to limit LLVM's Python support to 2.7. Now that both LLVM and LLDB both support Python 3, there's no longer a need to put an arbitrary limit on this. However, instead of removing the variable, D64443 <https://reviews.llvm.org/D64443> expanded the list , which has the (presumably unintentional) side-effect of expression preference for Python 3. Instead, we should just not set the list at all, and let CMake pick whatever Python interpreter you have in your path.


Repository:
  rL LLVM

https://reviews.llvm.org/D64894

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -641,8 +641,6 @@
 
 include(HandleLLVMOptions)
 
-# We support both Python 2 and 3.
-set(Python_ADDITIONAL_VERSIONS 3.7 3.6 3.5 2.7)
 include(FindPythonInterp)
 if( NOT PYTHONINTERP_FOUND )
   message(FATAL_ERROR


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64894.210442.patch
Type: text/x-patch
Size: 359 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190717/b6e2c8c7/attachment.bin>