[PATCH] D64879: llvm-pdbdump: Fix several smaller issues with injected source compression handling

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with a suggestion



================
Comment at: llvm/lib/DebugInfo/PDB/Native/NativeEnumInjectedSources.cpp:20
 
-Expected<std::string> readStreamData(BinaryStream &Stream) {
-  uint32_t Offset = 0, DataLength = Stream.getLength();
+Expected<std::string> readStreamData(BinaryStream &Stream, uint64_t Limit) {
+  uint32_t Offset = 0;
----------------
Perhaps Limit should be uint32_t since PDBs have some inherent 32-bit size limitations, and this is PDB-specific code? It would avoid the casts for std::min.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64879/new/

https://reviews.llvm.org/D64879