[PATCH] D63885: [LOOPINFO] Introduce the loop guard API.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 10:04:20 PDT 2019


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Took a fresh look at the patch.  The currently posted revision still uses PostDominatorTree.  As previously described, I feel doing so is a very bad idea.  As I will not LGTM the patch with this present, I stopped reading there and did not bother to review further.

To be clear here, I am not *objecting* to *someone else* reviewing the patch.  I'm simply stating that *I* will not sign off on this patch in the current form as it doesn't achieve an objective I find useful.  (i.e. It doesn't result in something I can use or build upon in existing transforms passes.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63885/new/

https://reviews.llvm.org/D63885





More information about the llvm-commits mailing list