[PATCH] D64088: [DDG] DirectedGraph as a base class for various dependence graphs such as DDG and PDG.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 08:55:26 PDT 2019


Meinersbur accepted this revision.
Meinersbur added a comment.

LGTM



================
Comment at: llvm/unittests/ADT/DirectedGraphTest.cpp:20
+
+using namespace llvm;
+
----------------
fhahn wrote:
> `using` should not be needed, as the code below is wrapped in `namespace llvm`.
@bmahjour This was a small issue with obvious resolution; I don't think you would need to wait for another LGTM for this change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64088/new/

https://reviews.llvm.org/D64088





More information about the llvm-commits mailing list