[PATCH] D64642: [AMDGPU] Tune inlining parameters for AMDGPU target

Daniil Fukalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 07:24:46 PDT 2019


dfukalov marked 2 inline comments as done.
dfukalov added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:883
   //
-  // Vector bonuses: We want to more aggressively inline vector-dense kernels
-  // and apply this bonus based on the percentage of vector instructions. A
----------------
eraman wrote:
> The comment block explaining vector bonuses is still relevant after this change. Instead of removing  it, you should modify it to say the bonus percentage is target dependent. 
the comment was not removed but moved to TargetTransformInfo.h where to new function. And note about target was added also.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64642/new/

https://reviews.llvm.org/D64642





More information about the llvm-commits mailing list