[PATCH] D64802: [llvm-ar][test] Add tests failing on Darwin

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 06:48:23 PDT 2019


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/tools/llvm-ar/extract.test:1
+## Test extract operation.
+# XFAIL: darwin
----------------
Can you check if the file uses the \r\n ending?  Some other tests you added did that. I just fixed them in r366324.


================
Comment at: test/tools/llvm-ar/extract.test:9
+RUN: llvm-ar x %t/empty.a 2>&1 \
+RUN:   | FileCheck --allow-empty /dev/null --implicit-check-not={{.}}
+
----------------
`| count 0`

Sorry I suggested this pattern before.. I recall a better one now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64802/new/

https://reviews.llvm.org/D64802





More information about the llvm-commits mailing list