[PATCH] D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 04:46:26 PDT 2019


jhenderson added a comment.

I feel look we've lost some test coverage here: a number of the checked fields have gone from being non-zero to being zero. This means that we're no longer testing that the property is actually read and printed correctly, so I think the YAML needs updating in these cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64800/new/

https://reviews.llvm.org/D64800





More information about the llvm-commits mailing list