[PATCH] D64841: Add github-release.py script

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 02:40:49 PDT 2019


hans added a comment.

My initial thought when I saw the filename was that this was a github version of test-release.sh. Which we'll need too, but it's not this one :-) What do you think about renaming to github-upload-release.py, or something else that has "upload" in the name to make it more explicit?

This is super cool! I just looked at https://github.com/llvm/llvm-project/releases

Should we be using this to host binaries from now on, and link to them from http://releases.llvm.org/ (ah, I see you did this for 7.1.0 already; I guess I'm not keeping up).



================
Comment at: llvm/utils/release/github-release.py:17
+# Create a new release from an existing tag:
+# ./github-release.py --token $github_token --release 8.0.1-rc4 create
+#
----------------
Where does one get the $github_token?


================
Comment at: llvm/utils/release/github-release.py:23
+# You can upload as many files as you want at a time and use wildcards e.g.
+# ./github-release.py --token $github_token --release 8.0.1-rc4 upload --files *.src.*
+#===------------------------------------------------------------------------===#
----------------
If I mess up, is there somewhere I can go to remove files? Does a new upload overwrite old ones?


================
Comment at: llvm/utils/release/github-release.py:31
+def create_release(repo, release, tag = None, name = None, message = None):
+
+    if not tag:
----------------
ultra nit: This blank line seems unnecessary


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64841/new/

https://reviews.llvm.org/D64841





More information about the llvm-commits mailing list