[PATCH] D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities.

Tue Jul 16 16:53:45 PDT 2019

lhames marked an inline comment as done.
lhames added a comment.

In D64609#1588195 <https://reviews.llvm.org/D64609#1588195>, @sgraenitz wrote:

> - 72 work with `orc-lazy` https://reviews.llvm.org/differential/diff/210161/

That’s pretty encouraging. The main wrinkle is the remote tests: orc-lazy is currently running in-process only, so these tests aren’t properly testing remote-jitting support. I will see if I can get the remote-execution utility working with orc-lazy mode. That probably won’t make the branch cut-off, but hopefully can be done soon enough that we can cherry- pick before the 9.0 release.

Long term I would like to reconsider these tests. They were added in an ad-hoc fashion and many would now be better expressed as rtdyld or jitlink tests (neither of which were available at the time). I won’t have time to audit them before the release though, so perhaps the best option would be to pull them in under a new directory name (OrcLazy-LegacyTests?) in LLVM 9.0.

What do you think?

================
Comment at: tools/lli/lli.cpp:94
                                            "orc-mcjit",
                                            "Orc-based MCJIT replacement"),
                                 clEnumValN(JITKind::OrcLazy,
----------------
sgraenitz wrote:
> `Orc-based MCJIT replacement (deprecated)`?
Good idea. I will update the patch in a moment.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64609/new/

https://reviews.llvm.org/D64609