[PATCH] D64797: [tools] [llvm-nm] Revert rL365889

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 15:43:39 PDT 2019


rupprecht added a comment.

In D64797#1587681 <https://reviews.llvm.org/D64797#1587681>, @abrachet wrote:

> I got it to work. The revert is here rL366219 <https://reviews.llvm.org/rL366219>. I think it didn't work because I always clone with --depth 1? So I just created a fresh clone.


Yes, `git llvm revert` is ultimately a wrapper around `git revert <git commit that git llvm finds>`, so if you don't have the commit in your history (with `--depth 1` you won't have anything), it won't work.
Certainly we could make it print a better error message, and also handle other call signs (rLNNNNNN, rCNNNNNN, rLLDNNNNNN, etc.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64797/new/

https://reviews.llvm.org/D64797





More information about the llvm-commits mailing list