[PATCH] D64814: [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 14:20:30 PDT 2019


Xiangling_L added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/P9InstrResources.td:151
     (instregex "NEG(8)?$"),
-    (instregex "ADDI(S)?toc(HA|L)$"),
+    (instregex "ADDI(S)?toc(HA8|HA|L)$"),
     COPY,
----------------
jsji wrote:
> Do we have plan to add `ADDItocL8` as well? 
> Why not use `(8)?` so that we don't need to update this again for `ADDItocL8` ?
Thank you for your suggestion, I will update it to use `(8)?`. And we haven't spot any place where `ADDItocL` is needed on AIX since AIX is always toc-referenced. So I guess probably we don't need to update it for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64814/new/

https://reviews.llvm.org/D64814





More information about the llvm-commits mailing list