[PATCH] D64746: Add constrained intrinsics for lrint and lround

Tue Jul 16 13:23:34 PDT 2019

cameron.mcinally added inline comments.

================
Comment at: docs/LangRef.rst:15724
+mode is determined by the runtime floating-point environment.  The rounding
+mode argument is only intended as information to the compiler.
+
----------------
kpn wrote:
> andrew.w.kaylor wrote:
> > We should describe what is returned if the value is too large to be represented as a long. The llvm.lrint doesn't do that either, but it should too.
> What do we want this to be? My draft copy of C99 says the return value is "unspecified". What does that translate to in LLVM-land? Is this listed in IEEE 754?
That should throw an Invalid exception. And I think we agreed in your other Diff that it should return a poison value.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64746/new/

https://reviews.llvm.org/D64746