[PATCH] D63713: WIP: DataExtractor error handling

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 07:03:53 PDT 2019


labath updated this revision to Diff 210090.
labath added a comment.

- update the patch to reflect our offline conversation with @dblaikie. We decided to go for the API which makes most sense (i.e. skip all reads as soon as one of them returns an error), at least until there is evidence that this makes a difference in practice (one can always prove that there is a slowdown here with a suitable micro-benchmark).
- add tests for the new APIs
- move the refactoring of other parsing classes into a separate patch (keeping this patch solely about DataExtractor).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63713/new/

https://reviews.llvm.org/D63713

Files:
  include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h
  include/llvm/Support/DataExtractor.h
  lib/DebugInfo/DWARF/DWARFDataExtractor.cpp
  lib/Support/DataExtractor.cpp
  unittests/Support/DataExtractorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63713.210090.patch
Type: text/x-patch
Size: 19175 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190716/fc80f2cd/attachment.bin>


More information about the llvm-commits mailing list