[PATCH] D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs"

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-hash-symbols.test:78
 
+# RUN: yaml2obj --docnum=2 %s -o %t1-x86_64.o
+# RUN: llvm-readelf --hash-symbols %t1-x86_64.o | FileCheck %s --check-prefix HASH-X86-64
----------------
I don't think it's the x86_64 bit that's important, if I'm not mistaken, merely the 64-bit nature of the ELF, so perhaps simplify the above i386 naming to simply "32" and this x86_64 to simply "64".


================
Comment at: test/tools/llvm-readobj/elf-hash-symbols.test:120
+      - Tag:   DT_HASH
+## 0x2b8 + PT_LOAD's p_offset == offset of .hash
+        Value: 0x00000000000002b8
----------------
Why is this 0x2be, rather than 0x0 like in the 32-bit case?

Worth a comment saying what "0x2b8" (and "0x2e4" below) represent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64788/new/

https://reviews.llvm.org/D64788