[PATCH] D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.

[Alex Bradbury via Phabricator via llvm-commits]

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM (two minor comments in-line). Pleas go ahead and commit - thanks!



================
Comment at: include/llvm/MC/MCFixup.h:147
+  /// It is an error to pass an unsupported size.
+  static MCFixupKind getKindForSizeInBits(unsigned Size, bool isPCRel) {
+    switch (Size) {
----------------
isPCRel -> IsPCRel


================
Comment at: include/llvm/MC/MCFixup.h:153
+      if (isPCRel)
+        llvm_unreachable("Invalid pc-relative fixup size!");
+      else
----------------
Can change if(foo)+llvm_unreachable to an assert


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58335/new/

https://reviews.llvm.org/D58335