[PATCH] D64544: [DWARF] Add more error handling to debug line parser.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 15 13:29:20 PDT 2019


dblaikie added a comment.

Looks like this code already had rudimentary error handling along this codepath where the assert is (the function returns empty, which returns false, which becomes an error further up, I think?) - and adding more descriptive/precise error handling along this path is probably good - but probably also means more testing is required to demonstrate all the new error results/messages/codepaths?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64544/new/

https://reviews.llvm.org/D64544





More information about the llvm-commits mailing list