[PATCH] D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Analysis/SearchVectorFunctionSystem.h:110
+                                  .Case("Us", ParameterKind::OMP_LinearUValPos)
+                                  .Case("u", ParameterKind::OMP_Uniform);
+
----------------
aranisumedh wrote:
> jdoerfert wrote:
> > What is the default here? What happens for bad inputs?
> Should I add an assert before the StringSwitch? 
> 
> Or add OMP_Unknown to handle such cases?
I would prefere the `OMP_Unknown` case but I am probably fine with any error checking solution. I mainly want to avoid silent errors.


================
Comment at: llvm/include/llvm/Analysis/SearchVectorFunctionSystem.h:216
+  }
+};
+
----------------
aranisumedh wrote:
> jdoerfert wrote:
> > It seems the new pass manager interface is missing.
> Could you share pointers to how to add a new pass using the new pass manager interface?
Take a look at other patches that do it, e.g., D64185


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64095/new/

https://reviews.llvm.org/D64095