[PATCH] D64707: [x86] try harder to form LEA from ADD to avoid flag conflicts (PR40483)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 15 10:33:30 PDT 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:2482
+      case X86ISD::AND:
+        return true;
+      default:
----------------
Should we make sure the flag output has a user? ADC/SBB could definitely only have a live flag input. Not sure about the others.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64707/new/

https://reviews.llvm.org/D64707





More information about the llvm-commits mailing list